erts: two FP exception fixes #707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change erts/configure.in to force-disable FP exceptions if the VM is compiled by clang/llvm. clang/llvm generates FP code which does not work with FP exceptions (whether unmasked as used in the Erlang VM, or masked followed by tests of which are signalled). This is a known long-standing problem. - Increase buffer size in erts_fp_check_init_error(). The current size is too small for 64-bit machines, causing messages to be truncated and making debugging more difficult.
|
Patch has passed first testings and has been assigned to be reviewed I am a script, I am not human |
|
Don't bother, I'll do the split. |
|
Merged to master at 0a3dbbc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the VM is compiled by clang/llvm. clang/llvm generates FP
code which does not work with FP exceptions (whether unmasked
as used in the Erlang VM, or masked followed by tests of
which are signalled). This is a known long-standing problem.
The current size is too small for 64-bit machines, causing
messages to be truncated and making debugging more difficult.