kernel: make printing strings with ANSI SGR escapes faster #7092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frazze-jobb
added
team:VM
CT Test Results 2 files 65 suites 1h 5m 1s ⏱️ For more details on these failures, see this check. Results for commit cf4241b. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Printing a long string with ANSI escapes is very slow on Erlang/OTP 26 RC2 which is caused by calling re:run/3 nifs a bunch of times. Compiling the regex did not make it fast enough, so SGR (Select Graphic Rendition) escapes are dealt separately with an erlang function which is what most people use escapes for. See erlang#7040
frazze-jobb
force-pushed
the
frazze/kernel/faster_re_sgr_escapes
branch
from
aade90c
to
cf4241b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Printing a long string with ANSI escapes is very slow on Erlang/OTP 26 RC2 which is caused by calling re:run/3 nifs a bunch of times. Compiling the regex did not make it fast enough, so SGR (Select Graphic Rendition) escapes are dealt separately with an erlang function which is what most people use escapes for. See #7040