Customize SASL error_logger file opening modes

[saleyn]

Include the ability to open a SASL error log file in append mode
at startup vs currently implemented "rewrite-always" mode.

Note: this is a replacement of pull request #628, which is rebased on master.

[saleyn]

Looking into why the test case is failing on the master branch

[OTP-Maintainer]

Patch has passed first testings and has been assigned to be reviewed

---

I am a script, I am not human

---

[bjorng]

The first problem with the log_file test case is that log_file/1 is not exported. But then there remains at least one more problem.

[saleyn]

I fixed the export, but I have a little problem figuring out how to force sasl application at startup not to overwrite the sasl_error_logger environment variable, which I set in the test case:

    SaslEnv = application:get_all_env(sasl),
    lists:foreach(fun({E,_V}) -> application:unset_env(sasl,E) end, SaslEnv),

    ok = application:set_env(sasl,sasl_error_logger,{file, File}),
    ok = application:start(sasl),

The problem is that sasl application has a {env, [...]} clause in its app file, which wipes out and ignores my test setting causing the test to fail. Any ideas how to force the variable to persist through sasl restart?

---

This problem was addressed on the mailing list using application:set_env/4 passing [{persistent, true}]

[OTP-Maintainer]

Patch has passed first testings and has been assigned to be reviewed

---

I am a script, I am not human

---

[saleyn]

The problems have been fixed.

[bjorng]

Thanks! We will test the branch in our daily builds.

[OTP-Maintainer]

Patch has passed first testings and has been assigned to be reviewed

---

I am a script, I am not human

---

[bjorng]

Merged.