stdlib: make it possible to list local functions and types

[frazze-jobb]

introducing lf(), lt(), lr() to list local functions, types and
records respectively.
introducing fl(), ff(), tf() to remove locally defined types
and functions.
introducing save_module(FilePath) that saves local defined
functions and types to given filename.
updating fd to store the original function definition. updating rd, rf to accurately add and remove locally defined records
to local table.

[garazdawi]

I'll do a review of the code later, but maybe there should be tests that the function do what they are supposed to?

[garazdawi]

shell_default:help() needs to be updated, but otherwise this looks good to me.

[garazdawi]

Suggested change

	"-spec my_func(X) -> X.\n my_func(#svej{a=A}) -> A.\n"
	"-spec my_func(X) -> X.\n"
	"my_func(#svej{a=A}) -> A.\n"

for consistency

[garazdawi]

Suggested change

	"ok.\nok.\n-spec my_func(X) -> X.\nmy_func(X) ->\n X.\n\n.\nok.\n" = t(
	"ok.\nok.\n-spec my_func(X) -> X.\nmy_func(X) ->\n X.\n\n.\nok.\n" = t(
	^^^^^^^

Why are there three newlines here? Seems a bit excessive.

[garazdawi]

Suggested change

	"-export(["++[atom_to_list(F)++"/"++integer_to_list(A)||{F,A}<-local_defined_functions(FT)]++"]).\n\n"++
	Exports = [atom_to_list(F)++"/"++integer_to_list(A)||{F,A}<-local_defined_functions(FT)],
	"-export(["++lists:join(",",Exports)++"]).\n\n"++

Need to add , inbetween exports. Also should probably be a test for multiple functions when saving module to make sure it works.

[garazdawi]

I would have expected this to take two arguments, FuncName and Arity, not a two tuple.

[garazdawi]

Suggested change

	lists:join($\n,lists:map(fun(Key) ->
	Spec = maps:get(Key, Output_function_specs, nospec),
	Def = maps:get(Key, Output_functions, nodef),
	case {Spec, Def} of
	{nospec, _} -> Def;
	{_, nodef} ->
	{FunName, Arity} = Key,
	Spec ++ "%% " ++ atom_to_list(FunName) ++ "/" ++ integer_to_list(Arity) ++ " not implemented";
	{_, _} -> Spec ++ Def
	end
	end,
	Keys)).
	string:trim(lists:join($\n,lists:map(fun(Key) ->
	Spec = maps:get(Key, Output_function_specs, nospec),
	Def = maps:get(Key, Output_functions, nodef),
	case {Spec, Def} of
	{nospec, _} -> Def;
	{_, nodef} ->
	{FunName, Arity} = Key,
	Spec ++ "%% " ++ atom_to_list(FunName) ++ "/" ++ integer_to_list(Arity) ++ " not implemented";
	{_, _} -> Spec ++ Def
	end
	end,
	Keys))).

strip som trailing newlines

[garazdawi]

Suggested change

	case file:write_file(PathToFile, Output) of
	case file:write_file(PathToFile, unicode:characters_to_binary(Output)) of

To handle unicode function names... and maybe a test?

[github-actions]

CT Test Results

       2 files       92 suites   35m 40s ⏱️
2 004 tests 1 955 ✔️ 48 💤 1 ❌
2 308 runs  2 257 ✔️ 50 💤 1 ❌

For more details on these failures, see this check.

Results for commit a1c802f.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

• Complete CT logs (Download Logs)
• HTML Documentation (Download HTML Docs)
• Windows Installer

// Erlang/OTP Github Action Bot