-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdlib: display help output in expand area #7846
stdlib: display help output in expand area #7846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice feature! I would have thought that would have needed more code.
Add some tests and docs and this this is good to go.
lib/kernel/src/group.erl
Outdated
{_,Word,_} = edlin:over_word(Before, [], 0), | ||
Docs = case edlin_context:get_context(Before) of | ||
{function, Mod} when Word =/= [] -> try | ||
c:h1(list_to_atom(Mod), list_to_atom(Word)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if Mod
is something like 'OTP-PUB-KEY'
. If you use erl_scan:string/1
it will handle the '
for you.
Its pretty much useless without the paging PR, will finish that one before I finish this one. |
540118f
to
6b46430
Compare
CT Test Results 5 files 276 suites 2h 14m 28s ⏱️ For more details on these failures, see this check. Results for commit f075334. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
changed formatting of doc text
6b46430
to
f075334
Compare
Adds a keyboard hotkey to display help for the function or module directly before the cursor