ssl: Fix creation of process labels
#8465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 67 suites 48m 23s ⏱️ Results for commit ae97547. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
That was stumbling on the finish line ;) Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current generation of process labels from the given
Hostbreaks the ability to use local sockets (as can be easily seen from how I fixed it), specifically inssl:connect. While the ability to use local sockets is not officially supported and poses a rare edge case, I see no reason not to keep supporting it ATM, certainly not for the reason of generating a label.This PR also improves the label generated for IPv6 addresses. In the current implementation, it would be generated as a string of dot-separated decimals ("IPv4-style"), instead of as a string of colon-separated hexadecimals (the usual representation of IPv6 addresses).