PEP 756: The CPython 3.13 build system #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can include an Implementation section that lays out a high-level implementation plan. |
erlend-aasland
commented
Oct 9, 2023
| @@ -0,0 +1,155 @@ | |||
| PEP: 756 | |||
| Title: The CPython 3.13 build system. | |||
There was a problem hiding this comment.
Need a more fancy title.
|
Meta: perhaps we should merge the two PRs into one. |
* PEP 654, 678, 680: Mark as Final * PEP 654: Add Discussions-To * PEP 654: Add Resolution * PEP 678, 680: Update Post-History * PEP 654, 678, 680: Link to canonical docs * PEP 654, 707: Update Irit's email --------- Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
erlend-aasland
commented
Oct 10, 2023
Comment on lines
+43
to
+55
| A build system will be implemented with the goals of PEP 755 in mind: | ||
|
|
||
| - a unified build system that works on all :pep:`11` supported platforms | ||
| - correct and fast incremental builds | ||
| - deterministic builds | ||
| - it should be easy to constrain external dependencies | ||
| - cross-compilation support | ||
|
|
||
| A new build system should also have the following traits: | ||
|
|
||
| - good quality documentation | ||
| - an active community | ||
| - being actively developed |
There was a problem hiding this comment.
Put this into Rationale?
erlend-aasland
commented
Oct 10, 2023
Comment on lines
+113
to
+114
| Implementation | ||
| -------------- |
There was a problem hiding this comment.
Perhaps move this up in the hierarchy. Also: need to expand this section.
Suggested change
| Implementation | |
| -------------- | |
| Implementation | |
| ============== |
erlend-aasland
commented
Oct 10, 2023
Comment on lines
+96
to
+99
| 1. Compile and link the source files in :file:`Python/` into an object file. | ||
| This implies generating :file:`pyconfig.h` for macros needed in :file:`Python/`. | ||
| 2. Locate dependencies for and compile the ``_sqlite3`` extension module | ||
| 3. Add a target that regenerates Argument Clinic code |
There was a problem hiding this comment.
Expand on these; add rationale for each point.
erlend-aasland
commented
Oct 11, 2023
Comment on lines
+116
to
+117
| The authors suggest to hire a developer to work full-time on the final implementation, | ||
| as it will be a time-consuming task. |
There was a problem hiding this comment.
I'm not sure this should be in the PEP, but I think it will be crucial that someone is allowed to work full-time on this. Similar to how the BPO => GitHub Issues transition was carried through.
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: T. Wouters <thomas@python.org> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
standardize mod name The PEP says that the module name is "sentinels" (plural) but the example imports Sentinel from the "sentinel" (singular) module. Not absolutely sure which one is intended but recent standards (secrets, dataclasses) have used the plural. CLA for Python signed, in case that's needed. Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
* For most cases (including all PEP metadata), replace birth name with chosen name * Birth name has been retained in parentheses when this makes other references substantially clearer (e.g. references to mailing list posts, elected members of the inaugural Steering Council)
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
|
I'm planning to revisit this as a single PEP draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an early draft.