Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent Builds - xref interactions refinement #859

Merged
merged 3 commits into from
Mar 27, 2021

Conversation

ashleyjlive
Copy link
Contributor

As raised in #851 running releases concurrently (discovered by running rebar3 release --all) results in crashes within maybe_check_for_undefined_functions_/2 as it assumes the xref server is not already running.
This pull request has a separate xref server for each release name thereby allowing multiple releases to execute concurrently without crashing.

rlx_assemble:
• Ensure that `xref` servers are unique when performing validation against releases. This is required when performing concurrent releases where the call to `xref:start/2` may crash due to the process already running.
• Revert match on error in `add_project_apps_to_xref/3`.
@ferd ferd merged commit c93f22c into erlware:master Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants