Only overwrite erl with dyn_erl if dyn_erl exists #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Erlang builds might not have the dyn_erl executable, so we can't assume it exists. Only optionally overwrite it if it actually exists.
ferd
approved these changes
Sep 1, 2022
|
@ferd Thank you! Looking forwards to a minor Rebar 3 version with the fix 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Erlang builds might not have the
dyn_erlexecutable, so we can't assume it exists. Only overwrite it if it actually exists.I have only manually verified that this works with our GRiSP plug-in (which releases from a custom Erlang build without
dyn_erl). Couldn't figure out a simple way to test it. Let me know if you have any hints.