Allow HTTPS in SOAP request to WSDL #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinoski
requested changes
Dec 22, 2020
There was a problem hiding this comment.
Hi Jesse, thanks for this PR. To address my comment, you can either change it yourself or I can do it. If you decide to do it yourself, please amend your commit and force-push it so this change still has only a single commit. But if you want me to address it when I merge this, that's no problem, just let me know.
|
Hey Steve, revision done. Thanks! |
|
Thanks @choptastic ! |
|
Thanks, Steve! Cheers man!
…On Tue, Dec 22, 2020 at 10:48 AM Steve Vinoski ***@***.***> wrote:
Merged #411 <#411> into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#411 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABNRHBPPQTIVYKGHCCK373SWDEU5ANCNFSM4VFXWWUQ>
.
--
Jesse Gumm
Owner, Sigma Star Systems
414.940.4866 || sigma-star.com || @jessegumm
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you specify a remote WSDL as an HTTPS URL, it crashes. This tweak allows HTTPS as the WSDL URL as well.