Support multiline inputs #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On multiline inputs (`textarea` elements), hitting <kbd>Up</kbd>/<kbd>Down</kbd>, when there are multiple lines, needs to take over going back in history. Also <kbd>Shift</kbd>+<kbd>Enter</kbd> lets you add a new line. Other changes include my editor cleaning up trailing whitespaces, and adding strict mode 'coz it's good :) This is actually a port of changes we've been using for 1.5y now (see https://github.com/thelounge/lounge/blob/master/client/js/libs/jquery/inputhistory.js#L58-L71) and it has served us well so far. I'm trying to sync our changes with the upstream project so we can correctly refer to this package instead of keeping a copy of our own :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On multiline inputs (
textareaelements), hitting Up/Down, when there are multiple lines, needs to take over going back in history. Also Shift+Enter lets you add a new line.Other changes include my editor cleaning up trailing whitespaces (review with
?w=1in URL to ignore those), and adding strict mode 'coz it's good :)This is actually a port of changes we've been using for 1.5y now (see https://github.com/thelounge/lounge/blob/master/client/js/libs/jquery/inputhistory.js#L58-L71) and it has served us well so far. I'm trying to sync our changes with the upstream project so we can correctly refer to this package instead of keeping a copy of our own :)