-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alias #values_of to #plucks and #value to #pluck #15
Comments
I'm not going to clobber the AR method, even if I do wish pluck was implemented via Valium. This is unnecessary. |
Alright, I'm going to fork valium, add it, and release it as "plucked" with Thanks for looking at the issue. On Mon, May 20, 2013 at 3:54 AM, Ernie Miller notifications@github.comwrote:
Kurtis Rainbolt-Greene, Hacker |
@krainboltgreene best of luck if you decide to do so, but as someone who's done his fair share of overriding stock AR behavior in gems, I'd recommend against it. It'll lead to a world of hurt down the line, and bogus issues galore. There's a reason I immediate responded with "no." :) |
Particularly since in more recent AR versions, pluck does in fact support multiple values. |
Seems like an awfully trivial reason to fork. Not to mention that monkeypatching pre-existing methods from other libraries is the worst form of monkeypatching. |
ActiveRecord has a similar method called #pluck, and there's really no need for both, especially since #pluck only handles 1 argument.
The text was updated successfully, but these errors were encountered: