Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send POST request data in body instead of query params to avoid HTTP 414 errors #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

debreczeni
Copy link

avoid receiving 414 Request-URI Too Large and Oj::ParseErrors in turn

@codecov-commenter
Copy link

Codecov Report

Merging #41 into master will decrease coverage by 3.22%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #41      +/-   ##
===========================================
- Coverage   100.00%   96.77%   -3.23%     
===========================================
  Files            4        4              
  Lines           30       31       +1     
===========================================
  Hits            30       30              
- Misses           0        1       +1     
Impacted Files Coverage Δ
lib/pushover/message.rb 83.33% <50.00%> (-16.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd29a00...0b2f90d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants