Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean UP & Dockerization eos85a3 #1

Closed
GemmaTuron opened this issue Jul 11, 2023 · 8 comments
Closed

Clean UP & Dockerization eos85a3 #1

GemmaTuron opened this issue Jul 11, 2023 · 8 comments
Assignees

Comments

@GemmaTuron
Copy link
Member

No description provided.

@febielin
Copy link
Collaborator

This model has not passed actions. There is an empty output error.

🚨🚨🚨 Something went wrong with Ersilia 🚨🚨🚨

Error message:

Ersilia exception class:
EmptyOutputError

Detailed error:
Model API eos85a3:predict did not produce an output

@febielin
Copy link
Collaborator

I changed the Dockerfile to include pip install rdkit==2022.3.3 and this passed the local tests: local model test and local model build test.

I will now begin reformatting.

@febielin
Copy link
Collaborator

Here is an initial PR that I opened to see if the model works. All the checks seem to pass for now. Something that I find very strange is that the checks pass here, but my local tests don't pass.

In terms of reformatting, this is not entirely done. The model has finetune and grover, which I'm not entirely sure what to do with. I know grover cannot be deleted because of the main.py file within it, but what about the other files within the grover directory? Also, can finetune be deleted?

@GemmaTuron
Copy link
Member Author

Hi @febielin
The failing at the ersilia install step was due to Airtable being down, which is solved now.
Regarding the model:
As you might have seen, the model checkpoints are inside framework, not inside the right folder. And we either create a code folder and move all grover inside it.
You can get inspiration from the refactoring @emmakodes has been doing on another grover based model: https://github.com/ersilia-os/eos77w8

@GemmaTuron
Copy link
Member Author

Maybe I wait to merge your PR until you have had time to look at Emma's work and make any other changes you want in the model?

@febielin
Copy link
Collaborator

febielin commented Jul 20, 2023

@GemmaTuron

I've made the following changes to eos85a3:

  • moved grover into model/framework/code
  • moved finetune in checkpoints folder

Now, I'm getting an install ersilia error:
ERROR: Could not build wheels for ersilia, which is required to install pyproject.toml-based projects

The entire failed log file is here.

This cannot still be related to the Airtable issue, can it? There must be something else causing the install ersilia error.

I see that this is a shared problem.. Emma is also encountering the same error.

@GemmaTuron
Copy link
Member Author

Hi @febielin
Yes, thanks, as I mentioned in the meeting something has changed not on ersilia but perhaps in GitHub runners, we need a bit of time to identify the source of the error

@GemmaTuron
Copy link
Member Author

GemmaTuron commented Aug 1, 2023

@febielin

The workflows are now updated, but the model fetching is failing, please check, thanks!

GemmaTuron pushed a commit that referenced this issue Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants