Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md - Prevent service from running by disabling eruption systemd service script #8

Merged
merged 4 commits into from
Jul 18, 2020

Conversation

erockce
Copy link
Contributor

@erockce erockce commented Jun 29, 2020

Although I have the package installed, I don't have the kernel parameter set as described in the README.md and am able to prevent the eruption from running by simply disabling the service. I would ask that providing this information be described as an option for users.

Also prevent service from running by disabling the eruption.service.
Remove extra blank line.
@X3n0m0rph59
Copy link
Member

Hi! Thank you very much for your contribution!
The Eruption daemon may be started via an udev hotplug rule. It then will be started even if it is in disabled state.
To inhibit Eruption completely, the systemd unit needs to be masked.

$ sudo systemctl mask eruption.service

So it would not be completely true to state that one can inhibit the launch of Eruption by disabling the systemd unit!

@erockce
Copy link
Contributor Author

erockce commented Jul 4, 2020

Don't know what to tell you @X3n0m0rph59. But I can confirm without doubt that on Ubuntu 18.04, the eruption daemon will not start when the service is disable'd. Maybe something changed in newer versions of systemd in which you must use mask instead?

Disabling works with the package version you provided when I inquired about installation problems in issue #7.

Side note...I had time to play around more with Eruption and customize it today. Now that I have it how I like it, I kept the Eruption service running now :)!

Changed to using systemd mask option which works with systemd 237 on Ubuntu 18.04.
Copy link
Member

@X3n0m0rph59 X3n0m0rph59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contributions!
Please implement the suggested changes, so that I can merge your branch.

README.md Outdated
```sh
$ sudo systemctl disable eruption
$ sudo systemctl mask eruption
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be more specific, we should use: eruption.service

README.md Outdated
```
You can always re-enable the Eruption service with the command:
```sh
$ sudo systemctl enable eruption
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"sudo systemctl unmask eruption.service" would be the complement to "sudo systemctl mask eruption.service"

@X3n0m0rph59
Copy link
Member

Don't know what to tell you @X3n0m0rph59. But I can confirm without doubt that on Ubuntu 18.04, the eruption daemon will not start when the service is disable'd. Maybe something changed in newer versions of systemd in which you must use mask instead?

I think it is because the udev rules do not get loaded correctly on Ubuntu Bionic. Will have a look and supply a new package soon!

Side note...I had time to play around more with Eruption and customize it today. Now that I have it how I like it, I kept the Eruption service running now :)!

Glad to hear that! :-)

Update per PR comments.
Copy link
Contributor Author

@erockce erockce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated per comments.

@X3n0m0rph59 X3n0m0rph59 merged commit 52b5428 into eruption-project:master Jul 18, 2020
@erockce erockce deleted the patch-1 branch July 26, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants