Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe character can not be used within tables #184

Closed
Seldaek opened this issue Jun 5, 2014 · 8 comments
Closed

Pipe character can not be used within tables #184

Seldaek opened this issue Jun 5, 2014 · 8 comments
Labels

Comments

@Seldaek
Copy link

Seldaek commented Jun 5, 2014

Source:

Foo | Bar | State
------ | ------ | -----
`Code | Pipe` | Broken | Blank
`Escaped Code \| Pipe` | Broken | Blank
Escaped \| Pipe | Broken | Blank

Current Output (github markdown is also affected so this works as a demo of the problem):

Foo Bar State
`Code Pipe` Broken
Escaped Code | Pipe Broken Blank
Escaped Pipe Broken

Expected:

Foo Bar State
Code | Pipe Broken Blank
Escaped Code | Pipe Broken Blank
Escaped | Pipe Broken Blank
@JCMais
Copy link

JCMais commented Jun 5, 2014

Would be nice to report to the github team too: https://github.com/contact

@hkdobrev
Copy link
Contributor

hkdobrev commented Jun 6, 2014

@JCMais You should actually open an issue on the library they are using. It used to be redcarpet, I don't know if they've changed it.

@cebe
Copy link
Contributor

cebe commented Jun 6, 2014

already done as far as I see: composer/getcomposer.org#68 (comment)

@Seldaek
Copy link
Author

Seldaek commented Jun 7, 2014

I assumed that redcarpet is just wrapping hoedown since it says it uses sundown and sundown says it's deprecated and replaced by hoedown. I'll send a ping to github anyway to make sure this is on their radar.

@erusev
Copy link
Owner

erusev commented Jan 15, 2015

I believe that the latest release resolves this. You can test it in the demo.

@cebe
Copy link
Contributor

cebe commented Jan 15, 2015

Looks great, a little thing remaining:

`Escaped Code \| Pipe`

Parse result is Escaped Code | Pipe inside of tables but Escaped Code \| Pipe out side.

@erusev
Copy link
Owner

erusev commented Jan 15, 2015

@cebe

Right. I'll see what I can do about that.

erusev added a commit that referenced this issue Jan 15, 2015
@erusev
Copy link
Owner

erusev commented Jan 15, 2015

Thanks to the idea of @cebe this seems to be completely resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants