Add literalBreaks support #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line breaks will be converted to <br />
|
Could this perhaps be merged to a beta branch as well? It's missing in 1.8.0-beta-5 |
|
The original plan was to include it due to the required changes not being suited well to modification by an extension. I ended up making some other changes which instead ended up providing the tools to add this via an extension by preserving information about the number of line breaks encountered (#610), and providing a way to overload paragraph handling like other block types (#611). This is discussed a little in #597 (comment), which also talks in response to some pitfalls associated with literal breaks (since line breaks in markdown have syntactic meaning—and this essentially turns that off in cases). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line breaks will be converted to
<br />Closes #597