Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add invalidExts as an option #40

Merged
merged 1 commit into from
May 18, 2024
Merged

fix: add invalidExts as an option #40

merged 1 commit into from
May 18, 2024

Conversation

deepjoy
Copy link
Contributor

@deepjoy deepjoy commented May 18, 2024 •
edited
Loading

Also

  • places stricter type restriction when using options internally
  • removes unused options since default values are not clear

fixes #39

fix: eryue0220#39 add invalidExts as an option
163c247 
Also
* places stricter type restriction when using options internally
* removes unused options since default values are not clear
@deepjoy deepjoy changed the title fix: #39 add invalidExts as an option fix: add invalidExts as an option May 18, 2024
@eryue0220
Copy link
Owner

Thanks for your PR. When CI passes, I'll merge.

@eryue0220 eryue0220 merged commit e068055 into eryue0220:main May 18, 2024
11 checks passed
@eryue0220
Copy link
Owner

LGTM

@deepjoy deepjoy deleted the issue-39 branch May 18, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webpack and RSPack plugins fail when there are files with other extensions
2 participants
@deepjoy @eryue0220