Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It should't try to shim what is not possible #116

Closed
rosenfeld opened this issue Jun 26, 2012 · 2 comments
Closed

It should't try to shim what is not possible #116

rosenfeld opened this issue Jun 26, 2012 · 2 comments

Comments

@rosenfeld
Copy link

I'm getting this exception when using Serenade.js together with es5-shim:

https://github.com/kriskowal/es5-shim/blob/master/es5-shim.js#L691

Serenade.js will only use defineProperty if it is defined, but es5-shim will define it and throw an exception when used, so what is this useful for?

@kriskowal
Copy link
Member

I will accept a well-reviewed pull request that strategically separates dubious and aesthetic shims into separate files so they can be mixed and matched.

defineProperty is a tricky one since it can be partially shimmed in many engines and whether you should try depends on which engines you intend to support.

@kriskowal
Copy link
Member

I’ve separated the shams into es5-sham.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants