Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String#split broken with second argument #380

Closed
zloirock opened this issue Jan 26, 2016 · 2 comments
Closed

String#split broken with second argument #380

zloirock opened this issue Jan 26, 2016 · 2 comments

Comments

@zloirock
Copy link

Already 7 month. output is an array. Try typeof 'a b'.split(/ /, 1), for example, in IE8.

@ljharb
Copy link
Member

ljharb commented Jan 26, 2016

Thanks! 7 months with no reports likely means nobody's running into it, since using the second arg of split is exceedingly rare.

Fixed and will be released shortly as v4.5.1. I'll also release patches in the 4.1, 4.2, 4.3, and 4.4 lines just in case, since while rare, this could break code that depends on it pretty badly.

@ljharb ljharb closed this as completed in 7e41b59 Jan 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants