feat: Add is-core-module replacement #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`is-core-module` can be replaced the same way `is-builtin-module` can.
AbhiPrasad
commented
Jul 2, 2024
43081j
reviewed
Jul 2, 2024
|
|
||
| `is-builtin-module` has equivalent functionality built in to node itself. | ||
| [`is-builtin-module`](https://www.npmjs.com/package/is-builtin-module), [`builtin-modules`](https://www.npmjs.com/package/builtin-modules), and [`is-core-module`](https://www.npmjs.com/package/is-core-module) has equivalent functionality built in to Node itself for Node versions above `8.10.0`. |
There was a problem hiding this comment.
i wouldn't bother listing them since this list might grow
better to say something like:
is-builtin-module and similar packages have equivalent functionality built into Node itself as of version
8.10.0and above
|
@AbhiPrasad did you mean to close this? Any chance you can let me know so I know if we still need to do it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #72
is-core-modulecan be replaced the same wayis-builtin-modulecan.