Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce timestepsPerCollisionDetection factor #116

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Introduce timestepsPerCollisionDetection factor #116

merged 1 commit into from
Feb 16, 2022

Conversation

FG-TUM
Copy link
Collaborator

@FG-TUM FG-TUM commented Feb 15, 2022

Description

  • whole collision detection logic is only executed every N timesteps
  • new yaml parameter timestepsPerCollisionDetection
  • simulationloop return total number of collisions (for tests)

Related Pull Requests

Resolved Issues

How Has This Been Tested?

  • new test

@FG-TUM
Introduce timestepsPerCollisionDetection factor
c80ae20 
    - whole collision detection logic is only executed
        every N timesteps
    - new yaml parameter timestepsPerCollisionDetection
    - simulationloop return total number of collisions (for tests)
    - new test
@FG-TUM FG-TUM requested a review from gomezzz February 15, 2022 22:22
@FG-TUM FG-TUM self-assigned this Feb 15, 2022
gomezzz
gomezzz approved these changes Feb 16, 2022
View reviewed changes
Copy link
Collaborator

@gomezzz gomezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to merge, unless we want to address the upper bound here

src/ladds/Simulation.cpp Show resolved Hide resolved
@FG-TUM FG-TUM merged commit 9759f5b into main Feb 16, 2022
@FG-TUM FG-TUM deleted the decoupleCollisionAndPropagation branch February 16, 2022 09:00
@FG-TUM FG-TUM mentioned this pull request Feb 16, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gomezzz gomezzz gomezzz approved these changes

Assignees

@FG-TUM FG-TUM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow detached conjunction / integration timesteps
2 participants
@FG-TUM @gomezzz