Solved some Critical Issues in Formatting #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxime-esa
requested changes
Jun 23, 2021
maxime-esa
requested changes
Jun 23, 2021
maxime-esa
approved these changes
Jun 23, 2021
maxime-esa
approved these changes
Jun 23, 2021
|
@maxime-esa should I create a pull request to implement unit testing for this repo? |
maxime-esa
requested changes
Jun 24, 2021
opengeode/AdaGenerator.py
Outdated
| asn1_context = (f'\n{process_asn1}-Context ::='' SEQUENCE {\n' | ||
| + ",\n ".join(line.replace("_", "-").replace("'", '"') for line in context_elems) | ||
| + "\n}\n") | ||
| asn1_context = ("\n{}-Context ::= SEQUENCE {}\n\n".format("hello", "\n,\n ".join(line.replace("_", "-").replace("'", '"') for line in context_elems))) |
There was a problem hiding this comment.
Why is this still there? I thought you had reverted it?
There was a problem hiding this comment.
I really apologize for this. I changed butt not added in this commit I added code of my test version!
opengeode/AdaGenerator.py
Outdated
| f'function To_{sortAda} (Src : {fromMod}) return {toMod} ' | ||
| f"is ({toMod}'Enum_Val (Src'Enum_Rep));") | ||
| f"function To_{sortAda} (Src : {fromMod}) return {toMod} is \ | ||
| ({toMod}'Enum_Val (Src'Enum_Rep));") |
There was a problem hiding this comment.
Not a big fan of \ at the end of the lines, I prefer to keep it as it was
maxime-esa
approved these changes
Jun 24, 2021
maxime-esa
approved these changes
Jun 24, 2021
|
Thanks! About the unit tests, what do you have in mind? If the plan is to add some py.tests (in tests/pytests folder) then I fully approve |
|
Yes I will implement tests with pytest if you can create a task list and
set priorities it will help a lot!
…On Thu, Jun 24, 2021 at 5:36 PM Maxime Perrotin ***@***.***> wrote:
Thanks! About the unit tests, what do you have in mind? If the plan is to
add some py.tests (in tests/pytests folder) then I fully approve
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#83 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALY6IT5M2RM6ONSCXVZU5UDTUMRDPANCNFSM47FT3BBQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.