-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding linter tests to continuous integration in Pykep #137
Conversation
Thanks for this PR, I think its a great addition to have a linting build ... hopefully you will manage to have it green 👍 |
sure, I can make it green, and then mark it ready to review. |
54dba0c
to
49e949c
Compare
This cleans up the erroneous lint errors related to C-extensions.
68d4dbb
to
3d9035b
Compare
14f82e4
to
b6335c1
Compare
@darioizzo this is ready for review. As you see, I worked with @albertoibm on this change. The commit messages are self-descriptive. Let us know if this can be merged. A reasonable question to ask is whether we need a new workflow for lint, or if we should just run lint on every python-3x test |
hi @darioizzo - did you have a chance to take a look? Most changes should be full-positives. Only special questions I expect are related to installing dependencies. |
Had a look its fine as is. I am merging this for the upcoming release. I saw the dependencies added to PyPi, sure they provide a better pykep experience. Thanks for the PR!!! Keep 'em coming :) |
Issue #134 would be caught by a linter. It may be a good idea to implement lint checks for pykep. What do you think @darioizzo ?
This PR adds an extra build type which runs lint checks (and currently fails). A healthy lint check could keep those failures out.
This PR is a work in progress for now.