Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding linter tests to continuous integration in Pykep #137

Merged
merged 9 commits into from
Oct 15, 2020

Conversation

pabloem
Copy link
Contributor

@pabloem pabloem commented Sep 25, 2020

Issue #134 would be caught by a linter. It may be a good idea to implement lint checks for pykep. What do you think @darioizzo ?

This PR adds an extra build type which runs lint checks (and currently fails). A healthy lint check could keep those failures out.

This PR is a work in progress for now.

@darioizzo
Copy link
Member

Thanks for this PR, I think its a great addition to have a linting build ... hopefully you will manage to have it green 👍

@pabloem
Copy link
Contributor Author

pabloem commented Sep 29, 2020

sure, I can make it green, and then mark it ready to review.

@pabloem pabloem marked this pull request as ready for review October 2, 2020 20:07
@pabloem
Copy link
Contributor Author

pabloem commented Oct 2, 2020

@darioizzo this is ready for review.

As you see, I worked with @albertoibm on this change. The commit messages are self-descriptive. Let us know if this can be merged.

A reasonable question to ask is whether we need a new workflow for lint, or if we should just run lint on every python-3x test

@pabloem
Copy link
Contributor Author

pabloem commented Oct 13, 2020

hi @darioizzo - did you have a chance to take a look? Most changes should be full-positives. Only special questions I expect are related to installing dependencies.

@darioizzo
Copy link
Member

Had a look its fine as is. I am merging this for the upcoming release.

I saw the dependencies added to PyPi, sure they provide a better pykep experience.

Thanks for the PR!!! Keep 'em coming :)

@darioizzo darioizzo merged commit 23060c3 into esa:master Oct 15, 2020
@pabloem pabloem deleted the pycodestyle branch October 16, 2020 21:35
@pabloem pabloem mentioned this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants