develop -> release for Release 0.4.0 #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release -> develop
Release -> main
This affects situations where a user explicitly specifies the `backend` argument and uses a tensor for `integration_domain` at the same time. * If the `integration_domain`'s backend does not correspond to the `backend` argument value, prefer the `backend` argument and show a warning. In this case the `integration_domain`'s dtype is ignored, so a globally configured dtype is used instead. * If the `integration_domain`'s backend corresponds to the `backend` argument value, ignore the `backend` argument. In this case the `integration_domain`'s dtype is used and a globally configured dtype is ignored.
Tests with github actions work again after this change. The JAX developers have recently moved the wheel files for `jaxlib` with CUDA to a different webpage: jax-ml/jax@e780a40
Change the backend argument behaviour
Fixing build badge
… test-coverage
Disable autoblack action commits
* (fix): change to `static_argnums` to work around decorator * WORKFLOW: Format Python code with black --------- Co-authored-by: htoftevaag <htoftevaag@users.noreply.github.com>
* (fix): change to `static_argnums` to work around decorator * WORKFLOW: Format Python code with black * (feat): add newton-cotest integrator tests * WORKFLOW: Format Python code with black * (fix): re-compile per integrand because of different shapes * WORKFLOW: Format Python code with black * (chore): remove erroneous boole comments * (fix): add mc test * (chore): add note about `integrand` shape * (feat): switch to re-use fo the jit integral * (chore): address comments * (fix): increase test tolerance * (feat): add newton-cotest integrator tests * (fix): re-compile per integrand because of different shapes * WORKFLOW: Format Python code with black * (chore): remove erroneous boole comments * (fix): add mc test * (chore): add note about `integrand` shape * (feat): switch to re-use fo the jit integral * (chore): address comments * (fix): increase test tolerance --------- Co-authored-by: htoftevaag <htoftevaag@users.noreply.github.com>
Display test coverage reports on PRs
Fixing coverage workflow
* basic version of gauss-legendre * fstrings for my sanity * fstrings for my sanity * weights and points multidimensional * transform xi,wi correctly * basic version of gauss-legendre * fstrings for my sanity * fstrings for my sanity * weights and points multidimensional * transform xi,wi correctly * let function to integrate accept args, c.f. scipy.nquad * any edits * add numpy import * autoray * add Gaussian quadrature methods * fix import * change anp.inf to numpy.inf * fix interval transformation and clean up * make sure tensors are on same device * make sure tensors are on same devicepart 2 * make sure tensors are on same devicepart 3 * make sure tensors are on same devicepart 4 * make sure tensors are on same devicepart 5 * add special import * add tests to /tests * run autopep8, add docstring * (feat): cache for roots. * (feat): refactor out grid integration procedure * (feat): gaussian integration refactored, some tests passing * (fix): scaling constant * (chore): higher dim integrals testing * (feat): weights correct for multi-dim integrands. * (fix): correct number of argument. * (fix): remove non-legendre tests. * (fix): import GaussLegendre * (fix): ensure grid and weights are correct type * (style): docstrings. * (fix): default `grid_func` * (fix): `_cached_poi...` returns tuple, not ndarray * (fix): propagate `backend` correctly. * (chore): export base types * (feat): add jit for gausssian * (feat): backward diff * (fix): env issue * Fixed tests badge * (chore): cleanup * (fix): `intergal` -> `integral` * (chore): add tutorial * (fix): change to `argnums` to work around decorator * (fix): add fix from other PR * (feat): add (broken) tests for gauss jit * (chore): remove unused import * (fix): use `item` for `N` when `jit` with `jax` * (fix): `domain` for jit gauss `calculate_result` * (chore): `black` * (chore): erroneous diff * (chore): remove erroneous print * (fix): correct comment * (fix): clean up gaussian tests * (chore): add comments. * (chore): formatting * (fix): error of 1D integral * (fix): increase bounds. --------- Co-authored-by: ilan-gold <ilanbassgold@gmail.com> Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
* basic version of gauss-legendre * fstrings for my sanity * fstrings for my sanity * weights and points multidimensional * transform xi,wi correctly * basic version of gauss-legendre * fstrings for my sanity * fstrings for my sanity * weights and points multidimensional * transform xi,wi correctly * let function to integrate accept args, c.f. scipy.nquad * any edits * add numpy import * autoray * add Gaussian quadrature methods * fix import * change anp.inf to numpy.inf * fix interval transformation and clean up * make sure tensors are on same device * make sure tensors are on same devicepart 2 * make sure tensors are on same devicepart 3 * make sure tensors are on same devicepart 4 * make sure tensors are on same devicepart 5 * add special import * add tests to /tests * run autopep8, add docstring * (feat): cache for roots. * (feat): refactor out grid integration procedure * (feat): gaussian integration refactored, some tests passing * (fix): scaling constant * (chore): higher dim integrals testing * (feat): weights correct for multi-dim integrands. * (fix): correct number of argument. * (fix): remove non-legendre tests. * (fix): import GaussLegendre * (fix): ensure grid and weights are correct type * (style): docstrings. * (fix): default `grid_func` * (fix): `_cached_poi...` returns tuple, not ndarray * (fix): propagate `backend` correctly. * (chore): export base types * (feat): add jit for gausssian * (feat): backward diff * (fix): env issue * (feat): start small with special grid for thesis * (fix): correct `_grid_func` for `GridIntegrator` * (fix): use `static_argnums` * (feat): add boolean check * (fix): small dev changes. * (chore): add docs * (feat): add basic test * (style): change integration domain check location * Update torchquad/integration/utils.py Co-authored-by: Pablo Gómez <contact@pablo-gomez.net> * (fix): `linspace` doesn't take arrays for all backends * (fix): grid creation from flat array * (fix): no all for `tf`? * (fix): tf has no flatten * (chore): black * (fix): tf has no flatten (!?!?!?!) * (fix): try `reshape` with -1 * (chore): formatting --------- Co-authored-by: Erica <elastufka@gmail.com> Co-authored-by: Pablo Gómez <contact@pablo-gomez.net>
main -> develop for Release 0.4.0
(chore): add and/or clean up `Gaussian`/`GaussLegendre` docs
|
@ilan-gold no need to look in detail at the diff, these are your changes mostly anyways. But feedback on the proposed changelog above would be appreciated ✌️ quite possible that I missed something :) |
Maybe just "better support" - we always supported custom integrators to some degree. |
Updated :) |
ilan-gold
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following process in #172
Proposed changelog:
Changelog
Major
Minor
Resolved Issues
How Has This Been Tested?
TBD
Related Pull Requests
IntegrationGrid#173