Authentication #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
En la clase LoginViewController hay unos comentarios para intentar más adelante mejorar el label de “Terms & Conditions”
|
|
||
| @interface FormInputViewController : UIViewController | ||
|
|
||
| //- (BOOL)isValidEmail:(NSString *)email; |
There was a problem hiding this comment.
No subimos codigo comentado al repo salvo contadas excepciones, pero preferentemente no lo hacemos.
| -(void)validateLogin{ | ||
| LoginViewController * __weak weakSelf = self; | ||
| void(^successBlock)(void) = ^{ [weakSelf performSegueWithIdentifier:@"tabBarSegue" sender:self];}; | ||
| [self.viewModel isLogged:successBlock]; |
There was a problem hiding this comment.
IDEM, declara el bloque donde lo usas.
se creo la clase ValidationAnswerModel para las respuestas a las validaciones.
Uso de cocoapods para tratar las imágenes.
| //¿Está bien que la validación vaya tan abajo? | ||
| -(void)validateLogin{ | ||
| LoginViewController * __weak weakSelf = self; | ||
| if([self.viewModel isLogged]) |
There was a problem hiding this comment.
Siempre ponemos llaves, aunque sea una unica linea, por estilo.
There was a problem hiding this comment.
No hace falta hacer weak a self en este caso.
Leete eso aunque sea por encima para entender el concepto de por que puede haber retain cycles:
https://blackpixel.com/writing/2014/03/capturing-myself.html
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.