Add support to MySQL for keyword LIKE, add support to laravel 5.4.* for relation keys and other minor fixes #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of LIKE to make the match case insensitive according to the active locale. This is not in the SQL standard but is a PostgreSQL extension.
… or equal to) operators
esbenp
requested changes
Jul 27, 2017
src/EloquentBuilderTrait.php
Outdated
| { | ||
| // $value, $not, $key, $operator | ||
| extract($filter); | ||
|
|
||
| $table = $query->getModel()->getTable(); | ||
| $dbType = Config::get('database.default'); |
There was a problem hiding this comment.
I do not think this is the most optimal way to get the connection type. The database key can be any arbitrary value.
What about getting it from the queryBuilder, something like $queryBuilder->getConnection()->getDriverName(). I just quickly looked it up, so I am not 100% sure it is a viable option - could you look into it? :-)
There was a problem hiding this comment.
I looked for it and it works perfectly :D nice!
|
Done! :D |
|
Thanks :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keyword ILIKE can be used instead of LIKE to make the match case insensitive according to the active locale. This is not in the SQL standard but is a PostgreSQL extension.