Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention admin decorators in Django 3.2+. #10

Merged
merged 1 commit into from
Apr 7, 2021
Merged

docs: mention admin decorators in Django 3.2+. #10

merged 1 commit into from
Apr 7, 2021

Conversation

ngnpope
Copy link
Contributor

@ngnpope ngnpope commented Feb 11, 2021

See https://docs.djangoproject.com/en/stable/releases/3.2/#new-decorators-for-the-admin-site

I'm creating this as a draft until Django 3.2 is released.

  • Prior to merging we should update the links to use .../stable/... instead of .../3.2/....

@coveralls
Copy link
Collaborator

coveralls commented Feb 19, 2021

Pull Request Test Coverage Report for Build 723320022

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 580753090: 0.0%
Covered Lines: 22
Relevant Lines: 22

💛 - Coveralls

@escaped
Copy link
Owner

escaped commented Feb 19, 2021

Wow... That's amazing that this somehow made its way into Django core :) Thanks a lot for persuing on this and doing all the hard work. ❤️

I guess it would be great to reference this project in Django as well, so people are able to use this feature in earlier versions. @pope1ni Do you think that feasible?
Additionally, it would make sense to slightly update this repo as well, so the function signature is compatible with the official version (#12).

@ngnpope
Copy link
Contributor Author

ngnpope commented Feb 19, 2021

Wow... That's amazing that this somehow made its way into Django core :) Thanks a lot for persuing on this and doing all the hard work. ❤️

Thanks! I think it'll be handy for people new to Django and make these options more discoverable.

I guess it would be great to reference this project in Django as well, so people are able to use this feature in earlier versions. @pope1ni Do you think that feasible?

I'm not sure what would be feasible or not here. Perhaps you could speak to one of the Django fellows about this.

Additionally, it would make sense to slightly update this repo as well, so the function signature is compatible with the official version (#12).

Yes, I did notice that the signature was different here using the function attribute names. I made a decision when implementing the decorators to remove some of the verbosity as we had an opportunity to clean up the API and make it more friendly. See django/django#13532.

@ngnpope ngnpope changed the title Added note about admin decorators in Django 3.2+. docs: mention admin decorators in Django 3.2+. Apr 6, 2021
@ngnpope ngnpope marked this pull request as ready for review April 6, 2021 15:10
@ngnpope
Copy link
Contributor Author

ngnpope commented Apr 6, 2021

@escaped Django 3.2 is released! I've updated this and marked it ready for review.

Copy link
Owner

@escaped escaped left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank you!

@escaped escaped merged commit 77a4c3c into escaped:master Apr 7, 2021
@ngnpope ngnpope deleted the patch-1 branch April 7, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants