Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify ffmpeg backend #24

Merged
merged 2 commits into from
Oct 21, 2020
Merged

refactor: simplify ffmpeg backend #24

merged 2 commits into from
Oct 21, 2020

Conversation

escaped
Copy link
Owner

@escaped escaped commented Oct 21, 2020

  • simplify the timecode extraction
  • add type hints to the backend

@coveralls
Copy link

coveralls commented Oct 21, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 319266910

  • 33 of 34 (97.06%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 91.484%
Changes Missing Coverage Covered Lines Changed/Added Lines %
video_encoding/backends/ffmpeg.py 30 31 96.77%
Totals Coverage Status
Change from base Build 318800913: 0.6%
Covered Lines: 293
Relevant Lines: 312
💛 - Coveralls

@escaped escaped force-pushed the refactor/simplify-ffmpeg-backend branch from 90931da to 0d7c94a Compare October 21, 2020 06:32
@escaped escaped merged commit 2ca93a7 into master Oct 21, 2020
@escaped escaped deleted the refactor/simplify-ffmpeg-backend branch October 21, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@escaped @coveralls