Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org_re #73

Open
dodona2 opened this issue Feb 28, 2023 · 1 comment · May be fixed by #74
Open

org_re #73

dodona2 opened this issue Feb 28, 2023 · 1 comment · May be fixed by #74

Comments

@dodona2
Copy link

dodona2 commented Feb 28, 2023

Line: 411 
;; hide tags
    (when epresent-hide-tags
      (goto-char (point-min))
      (while (re-search-forward
              (org-re "^\\*+.*?\\([ \t]+:[[:alnum:]_@#%:]+:\\)[ \r\n]")
              nil t)
        (push (make-overlay (match-beginning 1) (match-end 1)) epresent-overlays)
        (overlay-put (car epresent-overlays) 'invisible 'epresent-hide)))

--> causes
epresent.el: Warning: ‘org-re’ is an obsolete macro (as of 9.0); you can safely remove it.

--> however on removing
(org-re "^\\*+.*?\\([ \t]+:[[:alnum:]_@#%:]+:\\)[ \r\n]")
--> causes all the bullets are missing

sellout added a commit to sellout/epresent that referenced this issue Jun 30, 2023
This macro used to expand POSIX regex classes. But those are now supported in
Emacs’ regex directly.

Fixes eschulte#73.
@sellout sellout linked a pull request Jun 30, 2023 that will close this issue
@sellout
Copy link

sellout commented Jun 30, 2023

@dodona2 The deprecation message is certainly unclear – you can remove the call around the regeix. The regex is still necessary, but Emacs now supports that regex style directly. It previously (Emacs 23?) needed to have the [:alnum:] expanded before Emacs could parse it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants