Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMS_Vnuopc_Ld5_P1.1x1_mexicocityMEX.2000_DATM%1PT_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP.cheyenne_intel #89

Closed
jedwards4b opened this issue May 12, 2021 · 1 comment · Fixed by #92
Closed

SMS_Vnuopc_Ld5_P1.1x1_mexicocityMEX.2000_DATM%1PT_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP.cheyenne_intel #89

jedwards4b opened this issue May 12, 2021 · 1 comment · Fixed by #92
Assignees
@ekluzek
Labels
bug Something isn't working

Comments

@jedwards4b
Copy link
Contributor

This test fails due to an incorrect DATM_YR_ALIGN
@jedwards4b jedwards4b mentioned this issue May 12, 2021
Merged
12 tasks
@jedwards4b jedwards4b added the bug Something isn't working label May 12, 2021
@ekluzek
Copy link
Collaborator

ekluzek commented May 12, 2021

OK, I see the problem. For some of these single point forcing sites $DATM_YR_ALIGN is used for the align year, but the year start and end are hardcoded in the streams file. So the align year should be hardcoded as well. Especially for these cases where a single year is being used.

This is partially due to the issues surrounding #62. If we come up with a better solution there that should help prevent this type of problem in the future.

ekluzek added a commit to ekluzek/CDEPS that referenced this issue May 13, 2021
@ekluzek
Hardcode the align year to prevent the problem in ESCOMP#89, this isn…
c15126b 
…'t the best way to do this especially for the cases with multiple years, which you'll want the user to be able to customize
@ekluzek ekluzek mentioned this issue May 13, 2021
Merged
8 tasks
jedwards4b added a commit that referenced this issue May 14, 2021
@jedwards4b
Merge pull request #88 from jedwards4b/streams_improvement
b85dcd0 
### Description of changes
Improve support for user mods in *.streams.xml file.  If the file is found in the run directory it will be used for that data components streams.  I have added an xsd file as well to use with xmllint to assure the syntax of the file.  Due to namelist change in cmeps for multiple ice sheets all namelists changed and so new baselines, may12, were generated.  

### Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #): #79 

Are there dependencies on other component PRs
 - [ ] CIME (list)
 - [ ] CMEPS (list) 

Are changes expected to change answers?
 - [X] bit for bit
 - [ ] different at roundoff level
 - [ ] more substantial 

Any User Interface Changes (namelist or namelist defaults changes)?
 - [X] Yes Indirectly due to changes in glc (multiple ice sheet support)
 - [ ] No

Testing performed:
- [X] (required) aux_cdeps
   - machines and compilers: cheyenne intel 
   - details (e.g. failed tests): see issue #89 
- [ ] (optional) CESM prealpha test
   - machines and compilers
   - details (e.g. failed tests):

Hashes used for testing:
- [X] CIME
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch: master
  - hash: 353730e
- [X] CMEPS
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch: master
  - hash: cf0d47ba
- [ ] CESM
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch: nuopc_dev
  - hash:
jedwards4b added a commit that referenced this issue May 14, 2021
@jedwards4b
Merge pull request #92 from ekluzek/fixalignyear
35de2cb 
### Description of changes

Fix the align year issue. Fix a total of three issues.

### Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):
 Fixes #86
 Fixes #89 
 Fixes #91 

Are there dependencies on other component PRs: No
 - [ ] CIME (list)
 - [ ] CMEPS (list) 

Are changes expected to change answers?
 - [ x] bit for bit
 - [ ] different at roundoff level
 - [ ] more substantial 
Technically tests with the 1PT sites will be different because the start date is different.

Any User Interface Changes (namelist or namelist defaults changes)?
 - [ ] Yes
 - [ x] No
 
The one caveat is that now $DATM_YR is enabled to work for the 1PT sites

Testing performed:
- [ x] (required) aux_cdeps
   - machines and compilers:  cheyenne_intel
   - failed tests: Since I tested in a CTSM checkout the DLND test fails as expected, but as no changes to dlnd this shouldn't matter:
SMS_Vnuopc_Ld3.f09_f09_mg17.1850_SATM_DLND%SCPL_SICE_SOCN_SROF_SGLC_SWAV.cheyenne_intel

Hashes used for testing:
- [ ] CIME
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - tag: cime5.8.47
- [ ] CMEPS
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - tag; v0.10.0
- [ ] CTSM
  - repository to check out: https://github.com/jedwards4b/CESM.git
  - branch: neon_compsets
  - hash: ctsm5.1.dev038-43-gd43264c75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ekluzek ekluzek

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix align year ekluzek/CDEPS
2 participants
@jedwards4b @ekluzek