Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last use of unicode in the Python 3.5 version #6

Closed
esdalmaijer opened this issue Jan 10, 2017 · 2 comments
Closed

Last use of unicode in the Python 3.5 version #6

esdalmaijer opened this issue Jan 10, 2017 · 2 comments

Comments

@esdalmaijer
Copy link
Owner

In line 510, a list of values is converted to a list of unicode values:

responses = map(unicode, list(respdict[targetstring]))

This should be:

responses = map(str, list(respdict[targetstring]))

(Might also be good to update the comments.)

Would you mind picking this up, @kburk1997? :)
@kburk1997
Copy link
Contributor

Will do.

esdalmaijer added a commit that referenced this issue Jan 10, 2017
@esdalmaijer
Merge pull request #7 from kburk1997/master
4881f4f 
Fix issue #6
@esdalmaijer
Copy link
Owner Author

Thanks! Solved with your commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@esdalmaijer @kburk1997