Fixes for Perl 5.37.9 but no version bump. (Deal with eval exception text change) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rors In Perl/perl5#20357 the Perl dev team fixed some inconsistencies in how eval behaved with regard to compile errors. Prior that PR the exact outcome of a compile error varied with the type and number of errors that were encountered, sometimes calling $SIG{__DIE__}, sometimes not, sometimes outputing "Execution ... aborted" messages, sometimes not. With the merge of that PR the behavior is now consistent, and in particular for this module the "Execution ... aborted" message is now always output when there is a compile error. This patch strips this message off the error before rethrowing the exception with _croak(). This patch also includes some minor changes to the code to make it easier to debug the code being eval()ed which I left commented out. I figured if it was useful to debug this issue then it might useful again in the future.
…stinct var names Using "$FILE" in multiple tests causes the "not imported" warnings. Simply replacing them with distinct names causes the warnings to go away.
demerphq
force-pushed
the
yves/fix_for_perl_5_37_9_no_version_bump
branch
from
61bca8e
to
eff95bd
Compare
eserte
added a commit
that referenced
this pull request
Jul 8, 2023
|
Hi @demerphq, thanks for the PR. I will review it later, however, for a quick fix I will just do a release where the problematic test case is just marked as TODO (5.37.9 and later). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the 5.37.9 test failure, silences "not imported" warnings during test.
The test failure is related to: Perl/perl5#20357
Fixes: Perl/perl5#20864
This is the same as #5 but does not include any version bump or changes to the Makefile.PL