Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix segfaults due to parameter size mismatch #48

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix segfaults due to parameter size mismatch #48

wants to merge 3 commits into from

Conversation

chrstphrchvz
Copy link
Contributor

@chrstphrchvz
Copy link
Contributor Author

I would consider backporting https://core.tcl-lang.org/tk/info/0d9c0d50f9 (tcltk/tk@ca38684090) instead to fix many additional instances of this issue.

@chrstphrchvz
Copy link
Contributor Author

I changed my mind about backporting the entire upstream change; it shows only two more instances where length was changed from size_t to int, so I have incorporated those as well as removed redundant (int *) &length casts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrstphrchvz @khwilliamson