Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behatsdaa txns should be positive if expenses, same as the rest of the cards #852

Closed

Conversation

liranelisha
Copy link

@liranelisha liranelisha commented Apr 29, 2024

closes #851

This pull request contains a small but significant change in the src/scrapers/behatsdaa.ts file. The variantToTransaction function has been modified to no longer negate the customerPrice when assigning it to originalAmount. This means that the transaction amount will now be represented as a positive value, rather than a negative one.

@baruchiro
Copy link
Collaborator

Your change is wrong. As the comment said

The price is positive, make it negative as it's an expense

As you can see, I debugged your change, and it looks like the price is indeed positive, and we need to negate it.

image

Even while I'm writing this message, I'm confused because issue #851 and this PR are saying the opposite.

@baruchiro baruchiro closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Behatsdaa scrapper return wrong sign
2 participants