Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added options to catch all objects for the coadd #22

Merged
merged 1 commit into from
Mar 7, 2016
Merged

added options to catch all objects for the coadd #22

merged 1 commit into from
Mar 7, 2016

Conversation

beckermr
Copy link
Collaborator

@beckermr beckermr commented Mar 6, 2016

@esheldon: This PR should fix the remaining MEDS making issues. It has two features.

  1. I have added the config keyword 'coadd_bounds_buffer_rowcol'. This keyword adds (for the coadd only) a buffer in row,col (default: 1e-3). Anything within the coadd image boundaries (with this buffer added) is considered to be "in" the coadd image.
  2. The second config keyword I added is 'force_into_coadd_bounds'. This keyword clips the positions of all objects determined to be "in" the coadd image (including those from 1 above) to the boundaries of the coadd image (without the buffer from 1 above).

These two keywords combined means that an object falling outside the coadd image but in the buffer region will be marked as "in" the coadd image and then have its position moved to the edge of the image.

For our problems, this is the right thing to do. If you turn off 2 above, then you can keep objects near the edges of the coadd, but with their centers not "in" the coadd. This might be a useful feature in the future.

esheldon added a commit that referenced this pull request Mar 7, 2016
added options to catch all objects for the coadd
@esheldon esheldon merged commit 3a104e0 into esheldon:master Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants