Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests #51

Merged
merged 6 commits into from
Mar 29, 2021
Merged

Add unit tests #51

merged 6 commits into from
Mar 29, 2021

Conversation

esheldon
Copy link
Owner

No description provided.

@esheldon esheldon mentioned this pull request Mar 26, 2021
Open
@esheldon esheldon changed the title Tests Add unit tests Mar 26, 2021
beckermr
beckermr reviewed Mar 26, 2021
View reviewed changes
meds/defaults.py Outdated Show resolved Hide resolved
beckermr
beckermr reviewed Mar 26, 2021
View reviewed changes
meds/meds.py Outdated Show resolved Hide resolved
beckermr
beckermr reviewed Mar 26, 2021
View reviewed changes
Copy link
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Also

  • This extra file got committed meds/tests/.coverage. Maybe add to the .gitignore?
  • The extractors do not support extra extenions. This is probably fine. If it isn't, then I can add that.

@esheldon
Copy link
Owner Author

shall we merge this and add more tests later?

@esheldon esheldon merged commit 7eaf0e7 into master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckermr beckermr beckermr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esheldon @beckermr