Otp24 #136
Otp24 #136
Conversation
|
The tests are run for OTP 21.3 but |
And that explains the failure, but that makes it all a bit more complicated, because pg2 was completely removed with otp24, which means we could only support the last two major releases, or not support the last. Or do some hacks to compile different things with different versions 😕 |
|
yeah, that is known issues, and that's exactly the reason why we didn't have CI testing against OTP23. pg2 became deprecated since that release, but we didn't want to relax dialyzer/xref verification rules. |
|
I guess now, having 2 major OTP release with pg module, we can replace pg2 with pg. |
NelsonVides
requested review from
gustawlippa and
DenysGonchar
and removed request for
gustawlippa
| @@ -181,7 +181,6 @@ handle_call({change_rate_gradually, Name, LowRate, HighRate, | |||
| handle_call({stop, Name}, _From, State) -> | |||
| case all_processes(Name, stop) of | |||
| ok -> | |||
| pg2:delete(Name), | |||
There was a problem hiding this comment.
is group removed in this case? can we recreate the group with the same name after this?
There was a problem hiding this comment.
https://github.com/erlang/otp/blob/4d2a17302a79a86b6c74c769b9fafd9fbd9be516/lib/kernel/src/pg.erl#L21-L53 Here's an explanation, non-existent and empty groups are treated the same in this new implementation, the reason being agreement in the case of coming back from a network split.
|
Github actions have some issue with nifs for a wxWidget dep not being loaded, no idea why, but that doesn't happen locally on my system. Needs investigation. |
NelsonVides
force-pushed
the
otp24
branch
3 times, most recently
from
5a38029
to
ef80273
Compare
Use erlef/setup-beam@v1 Use rebar3 given by erlef/setup-beam@v1 Test only OTP23 and OTP23
This makes sure that attributes and compile flags aren't removed from the beam files and module_info() can still find them. Latest relx versions enforced stripping prod releases, so we need to explicitly say otherwise.
Loading everything reachable is an overkill, and sometimes means that some completely unneeded modules that cannot be loaded will introduce errors to the pipeline.
There was a problem hiding this comment.
It was surprisingly hard, but I really like the changes.
MB we should make a follow-up ticket to add a note regarding {debug_info, keep} relx flag in amoc documentation. I think it should be added here, near to -required_variable(...) attribute explanation.
Waiting for esl/amoc_rest#8