-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distribute modules as binaries #152
Conversation
see the diff between the original amoc_scenario and the extracted amoc_code_server modules delta <(git show @~:src/amoc_scenario.erl) src/amoc_code_server.erl
935ec6c
to
bff89d0
Compare
aeb5aa2
to
b1ffda0
Compare
bcfedb1
to
757f8dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small comments, plus two more points here:
- There's a page with all telemetry events exposed by amoc, all the telemetry changes and additions in this PR should be well documented there, so that writing handlers doesn't require browsing through the code.
amoc_scenario:terminate/1
isn't documented nor verified as optional.
Otherwise this PR is looking brilliant! 🤩
telemetry.md is already updated. |
Ah, see it now. Sorry, disadvantages of such a huge PR, too much diff to browse 🥲 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely fantastic, thank you for this huge work! 🤩
This PR introduces the following changes: