Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs #181

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix docs #181

merged 1 commit into from
Mar 4, 2024

Conversation

kamilwaz
Copy link

@kamilwaz kamilwaz commented Mar 4, 2024

This PR fixes the minor issues (such as broken links, invalid code) that I found while reading the docs.

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.08%. Comparing base (7b1ea3d) to head (349cee0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #181   +/-   ##
=======================================
  Coverage   75.08%   75.08%           
=======================================
  Files          31       31           
  Lines        1160     1160           
=======================================
  Hits          871      871           
  Misses        289      289           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the fixes! :)

* **Syntax:** A string describing how this variable is used, can be extracted by APIs to document the behavior
* **Example:** `description = "a description of this variable"`
* **Example:** `"a description of this variable"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this came from how it was done for MIM configuration modules, but here's not language agnostic, good catch! :D

```elixir
:amoc_dist.do(:my_scenario, 100, settings).
:amoc_dist.do(:my_scenario, 100, settings)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main reason my elixir code doesn't compile, those accidental commas I'm so used to! 😅

@NelsonVides NelsonVides merged commit f1d9152 into master Mar 4, 2024
6 checks passed
@NelsonVides NelsonVides deleted the guides branch March 4, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants