Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dialyzer from CT #63

Merged
merged 3 commits into from
Apr 10, 2018
Merged

Remove dialyzer from CT #63

merged 3 commits into from
Apr 10, 2018

Conversation

GalaxyGorilla
Copy link
Contributor

As promised in #62 ;)

I did some formatting/refactoring of the Makefile, I hope that's fine.

Copy link
Contributor

@michalwski michalwski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I had only one comment to the code. Thanks!

.travis.yml Outdated
@@ -13,7 +13,8 @@ addons:
- libexpat1-dev

install: make compile
script: make test
script:
- make test dialyzer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it be better to run test and dialyzed separately. The log in Travis will be a bit easier to analyse IMO.

@GalaxyGorilla
Copy link
Contributor Author

@michalwski fixed!

@michalwski michalwski merged commit d709c7c into esl:master Apr 10, 2018
@michalwski
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants