Add a workaround for enif_inspect_binary bug in ERTS < 9.0 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalwski
reviewed
May 22, 2018
There was a problem hiding this comment.
I'm used to functional code so reading this was a bit challenging.
It's good the workaround is applied only when needed. I wonder what's the impact of the workaround in terms of consumed memory mostly. Did you measure it @kzemek?
| class Version { | ||
| public: | ||
| Version(const std::string str) { | ||
| for (std::size_t i = 0; i < str.size();) { |
There was a problem hiding this comment.
I feel old reading this modern C++ code and having difficulties to understand it easily.
There was a problem hiding this comment.
@michalwski The strings are saved in RapidXML document's memory pool. We set the memory pool up to initial size of 10MB, and clear the pool before use in each NIF call. To have any impact on memory at all, the strings in a single #xmlel{} would have to take more than those 10MB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug caused previous results from enif_inspect_binary to sometimes be overwritten when calling enif_inspect_binary later. It was fixed in ERTS 9.0 which is included in Erlang 20+.