Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subelement_with_name_and_ns bug #38 #67

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

NelsonVides
Copy link

If we have list of elements:

  • [#xmlel{name = <<"a">>, attrs = [{<<"xmlns">>, <<"ns">>}]}, #xmlel{name = <<"a">>, attrs = [{<<"xmlns">>, <<"ns2">>}]}] and call exml_query:subelement_with_name_and_ns/3 with <<"a">> and <<"ns2">>, we will get:
  • currently - undefined
  • expected - #xmlel{name = <<"a">>, attrs = [{<<"xmlns">>, <<"ns2">>}]}]}

Fixes #38

If we have list of elements:
- [#xmlel{name = <<"a">>, attrs = [{<<"xmlns">>, <<"ns">>}]}, #xmlel{name = <<"a">>, attrs = [{<<"xmlns">>, <<"ns2">>}]}]
and call exml_query:subelement_with_name_and_ns/3 with <<"a">> and <<"ns2">>, we will get:
- currently - undefined
- expected - #xmlel{name = <<"a">>, attrs = [{<<"xmlns">>, <<"ns2">>}]}]}
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@chrzaszcz chrzaszcz merged commit 9814aa2 into master Nov 13, 2023
5 checks passed
@NelsonVides NelsonVides deleted the bugfix/subelement_with_name_and_ns branch November 13, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exml_query:subelement_with_name_and_ns
2 participants