Fix and improve the check for maximum element size #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 71.85% 72.12% +0.27%
==========================================
Files 7 7
Lines 1112 1123 +11
Branches 163 166 +3
==========================================
+ Hits 799 810 +11
Misses 313 313 ☔ View full report in Codecov by Sentry. |
chrzaszcz
force-pushed
the
max-element-size
branch
2 times, most recently
from
c9997a2
to
25bd9bd
Compare
The original option named 'max_child_size' had two major issues: 1. It only checked incomplete (chunked) elements 2. It also checked the stream opening tag Ad 1: Added a check for complete elements as well. The check prevents constructing the Erlang term. Ad 2: Modified the option name to 'max_element_size', and made it check the size of the stream-opening tag as well as sizes of any element. This makes sense because: - One could (maliciously or not) send a huge stream-opening tag - When infinite_stream is used, the elements are not children anyway, so the name was misleading. Other changes: - Updated error messages. - The check for incomplete elements was failing too soon - one more character should be accepted. Now at most max_element-size-1 characters are accepted, because we know that at least one more character will be parsed.
chrzaszcz
force-pushed
the
max-element-size
branch
from
25bd9bd
to
9d08ba5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original option named
max_child_sizehad two major issues:They are both addressed:
max_element_size. Wheninfinite_streamis used, the elements are not children anyway. The size of the stream-opening tag is still checked, but it is documented now. One could (maliciously or not) send a huge stream-opening tag, so the check makes sense.Other changes:
max_element-size - 1characters are accepted, because we know that at least one more character will be parsed.Recommended for the future: add OTP 26 to CI.