fix: ignore SpreadExpressions in no-only-tests and prefer-output-null

eslint-community · Jul 19, 2023 · 4924042 · 4924042
1 parent dea161d
commit 4924042
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/lib/rules/no-only-tests.js b/lib/rules/no-only-tests.js
@@ -36,6 +36,7 @@ module.exports = {
 
               const onlyProperty = test.properties.find(
                 (property) =>
+                  property.type === 'Property' &&
                   property.key.type === 'Identifier' &&
                   property.key.name === 'only' &&
                   property.value.type === 'Literal' &&

diff --git a/lib/rules/prefer-output-null.js b/lib/rules/prefer-output-null.js
@@ -48,7 +48,9 @@ module.exports = {
              */
             function getTestInfo(key) {
               if (test.type === 'ObjectExpression') {
-                return test.properties.find((item) => item.key.name === key);
+                return test.properties.find(
+                  (item) => item.type === 'Property' && item.key.name === key
+                );
               }
               return null;
             }

diff --git a/tests/lib/rules/no-only-tests.js b/tests/lib/rules/no-only-tests.js
@@ -23,7 +23,8 @@ ruleTester.run('no-only-tests', rule, {
           'foo',
           { code: 'foo', foo: true },
           RuleTester.somethingElse(),
-          notRuleTester.only()
+          notRuleTester.only(),
+          { ...otherOptions },
         ],
         invalid: [
           { code: 'bar', foo: true },

diff --git a/tests/lib/rules/prefer-output-null.js b/tests/lib/rules/prefer-output-null.js
@@ -25,6 +25,7 @@ ruleTester.run('prefer-output-null', rule, {
       new RuleTester().run('foo', bar, {
         valid: [],
         invalid: [
+          { ...otherOptions },
           {code: 'foo', output: 'bar', errors: ['bar']},
         ]
       });