Update: commit-message enforces issue ref style (fixes #56) #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@not-an-aardvark @gyandeeps Not sure why Travis is failing. Any ideas? |
|
i think 2 unit test from |
|
seems need to rebase. friendly ping @platinumazure |
platinumazure
force-pushed
the
commit-message-issue-number
branch
from
d6663ec
to
9cf77e7
Compare
|
@aladdin-add I've rebased-- thanks for pinging me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt at enforcing our issue reference guidelines in commit summaries (for single-commit PRs) and PR titles (for multiple-commit PRs).
Reference: https://eslint.org/docs/developer-guide/contributing/pull-requests#step2
Fixes #56.
Open to feedback on how things could be a little more readable-- unfortunately, readability suffered a bit when I was trying to fix some corner cases.