Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to eslint v9, eslint-config-eslint v10 #561

Merged
merged 3 commits into from
May 9, 2024
Merged

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented May 2, 2024

Prerequisites checklist

What is the purpose of this pull request?

Switches to using eslint v9 and eslint-config-eslint v10 to lint this project.

What changes did you make? (Give an overview)

  • Updated package.json to use ESLint v9 and eslint-config-eslint v10. Also bumped eslint plugins to the latest versions.
  • Added "overrides": { "eslint": "^9.2.0" } to package.json to make npm install work because eslint-plugin-jsx-a11y, eslint-plugin-react and eslint-plugin-react-hooks don't have eslint v9 in range in peer dependencies.
  • Updated eslint.config.js to use eslint-config-eslint 's base config for playground files, so that there's no need anymore to disable eslint-plugin-n rules. The previously used cjs config is for Node.js CommonJS projects, which Playground is not.
  • Used @eslint/compat on eslint-plugin-jsx-a11y, eslint-plugin-react and eslint-plugin-react-hooks as neither of these plugins officially supports eslint v9 yet (although only eslint-plugin-react throws errors like context.getScope is not a function).

Related Issues

No.

Is there anything you'd like reviewers to focus on?

Copy link

netlify bot commented May 2, 2024

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 9083a7d
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/663bdb3224ed2a0008af1111
😎 Deploy Preview https://deploy-preview-561--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 2, 2024

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit 9083a7d
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/663bdb32bd865300085bf556
😎 Deploy Preview https://deploy-preview-561--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 2, 2024

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 9083a7d
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/663bdb326bed6900081d9ff8
😎 Deploy Preview https://deploy-preview-561--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 2, 2024

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 9083a7d
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/663bdb320ada5000088b50aa
😎 Deploy Preview https://deploy-preview-561--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 2, 2024

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 9083a7d
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/663bdb3233e5090008e46615
😎 Deploy Preview https://deploy-preview-561--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 2, 2024

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 9083a7d
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/663bdb324165c400089be5de
😎 Deploy Preview https://deploy-preview-561--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 2, 2024

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 9083a7d
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/663bdb32e1e005000835ec4a
😎 Deploy Preview https://deploy-preview-561--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 2, 2024

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 9083a7d
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/663bdb32a384940008831080
😎 Deploy Preview https://deploy-preview-561--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdjermanovic mdjermanovic marked this pull request as ready for review May 8, 2024 20:15
@aladdin-add aladdin-add merged commit 6378214 into main May 9, 2024
37 checks passed
@aladdin-add aladdin-add deleted the eslint9 branch May 9, 2024 06:03
zhangenming pushed a commit to zhangenming/eslint.org that referenced this pull request Jul 26, 2024
* chore: switch to eslint v9, eslint-config-eslint v10

* use `@eslint/compat` from npm, use overrides instead of --forec

* bump eslint to v9.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants