Fix: no-useless-rename false positives (fixes #6266) (#6267)

Author: alberto

lib/rules/no-useless-rename.js

@@ -108,7 +108,8 @@ module.exports = {
                 return;
             }
 
-            if (node.imported.name === node.local.name) {
+            if (node.imported.name === node.local.name &&
+                    node.imported !== node.local) {
                 reportError(node, node.imported, node.local, "Import");
             }
         }
@@ -123,7 +124,8 @@ module.exports = {
                 return;
             }
 
-            if (node.local.name === node.exported.name) {
+            if (node.local.name === node.exported.name &&
+                    node.local !== node.exported) {
                 reportError(node, node.local, node.exported, "Export");
             }
 

tests/lib/rules/no-useless-rename.js

@@ -40,8 +40,11 @@ ruleTester.run("no-useless-rename", rule, {
         { code: "({foo: bar}) => {}", parserOptions: { ecmaVersion: 6 } },
         { code: "({foo: bar, baz: qui}) => {}", parserOptions: { ecmaVersion: 6 } },
         { code: "import * as foo from 'foo';", parserOptions: { ecmaVersion: 6, sourceType: "module" } },
+        { code: "import foo from 'foo';", parserOptions: { ecmaVersion: 6, sourceType: "module" } },
+        { code: "import {foo} from 'foo';", parserOptions: { ecmaVersion: 6, sourceType: "module" } },
         { code: "import {foo as bar} from 'foo';", parserOptions: { ecmaVersion: 6, sourceType: "module" } },
         { code: "import {foo as bar, baz as qux} from 'foo';", parserOptions: { ecmaVersion: 6, sourceType: "module" } },
+        { code: "export {foo} from 'foo';", parserOptions: { ecmaVersion: 6, sourceType: "module" } },
         { code: "export {foo as bar};", parserOptions: { ecmaVersion: 6, sourceType: "module" } },
         { code: "export {foo as bar, baz as qux};", parserOptions: { ecmaVersion: 6, sourceType: "module" } },
         { code: "export {foo as bar} from 'foo';", parserOptions: { ecmaVersion: 6, sourceType: "module" } },