Chore: convert remaining old-style context.report() calls to the new API (#7763)

Author: not-an-aardvark

lib/internal-rules/internal-no-invalid-meta.js

@@ -215,7 +215,7 @@ module.exports = {
 
             "Program:exit"() {
                 if (!isCorrectExportsFormat(exportsNode)) {
-                    context.report(exportsNode, "Rule does not export an Object. Make sure the rule follows the new rule format.");
+                    context.report({node: exportsNode, message: "Rule does not export an Object. Make sure the rule follows the new rule format."});
                     return;
                 }
 

lib/rules/accessor-pairs.js

@@ -139,9 +139,9 @@ module.exports = {
             }
 
             if (checkSetWithoutGet && isSetPresent && !isGetPresent) {
-                context.report(node, "Getter is not present.");
+                context.report({node, message: "Getter is not present."});
             } else if (checkGetWithoutSet && isGetPresent && !isSetPresent) {
-                context.report(node, "Setter is not present.");
+                context.report({node, message: "Setter is not present."});
             }
         }
 

lib/rules/block-scoped-var.js

@@ -47,10 +47,7 @@ module.exports = {
         function report(reference) {
             const identifier = reference.identifier;
 
-            context.report(
-                identifier,
-                "'{{name}}' used outside of binding context.",
-                {name: identifier.name});
+            context.report({node: identifier, message: "'{{name}}' used outside of binding context.", data: {name: identifier.name}});
         }
 
         /**

lib/rules/callback-return.js

@@ -164,7 +164,7 @@ module.exports = {
 
                 // as long as you're the child of a function at this point you should be asked to return
                 if (findClosestParentOfType(node, ["FunctionDeclaration", "FunctionExpression", "ArrowFunctionExpression"])) {
-                    context.report(node, "Expected return with your callback function.");
+                    context.report({node, message: "Expected return with your callback function."});
                 }
 
             }

lib/rules/camelcase.js

@@ -61,7 +61,7 @@ module.exports = {
         function report(node) {
             if (reported.indexOf(node) < 0) {
                 reported.push(node);
-                context.report(node, "Identifier '{{name}}' is not in camel case.", { name: node.name });
+                context.report({node, message: "Identifier '{{name}}' is not in camel case.", data: { name: node.name }});
             }
         }
 

lib/rules/complexity.js

@@ -91,7 +91,7 @@ module.exports = {
             }
 
             if (complexity > THRESHOLD) {
-                context.report(node, "Function '{{name}}' has a complexity of {{complexity}}.", { name, complexity });
+                context.report({node, message: "Function '{{name}}' has a complexity of {{complexity}}.", data: { name, complexity }});
             }
         }
 

lib/rules/consistent-this.js

@@ -43,9 +43,7 @@ module.exports = {
          * @returns {void}
          */
         function reportBadAssignment(node, alias) {
-            context.report(node,
-                "Designated alias '{{alias}}' is not assigned to 'this'.",
-                { alias });
+            context.report({node, message: "Designated alias '{{alias}}' is not assigned to 'this'.", data: { alias }});
         }
 
         /**
@@ -64,8 +62,7 @@ module.exports = {
                     reportBadAssignment(node, name);
                 }
             } else if (isThis) {
-                context.report(node,
-                    "Unexpected alias '{{name}}' for 'this'.", { name });
+                context.report({node, message: "Unexpected alias '{{name}}' for 'this'.", data: { name }});
             }
         }
 

lib/rules/default-case.js

@@ -81,7 +81,7 @@ module.exports = {
                     }
 
                     if (!comment || !commentPattern.test(comment.value.trim())) {
-                        context.report(node, "Expected a default case.");
+                        context.report({node, message: "Expected a default case."});
                     }
                 }
             }

lib/rules/func-names.js

@@ -86,11 +86,11 @@ module.exports = {
 
                 if (never) {
                     if (name) {
-                        context.report(node, "Unexpected function expression name.");
+                        context.report({node, message: "Unexpected function expression name."});
                     }
                 } else {
                     if (!name && (asNeeded ? !hasInferredName(node) : !isObjectOrClassMethod(node))) {
-                        context.report(node, "Missing function expression name.");
+                        context.report({node, message: "Missing function expression name."});
                     }
                 }
             }

lib/rules/func-style.js

@@ -44,7 +44,7 @@ module.exports = {
                 stack.push(false);
 
                 if (!enforceDeclarations && node.parent.type !== "ExportDefaultDeclaration") {
-                    context.report(node, "Expected a function expression.");
+                    context.report({node, message: "Expected a function expression."});
                 }
             },
             "FunctionDeclaration:exit"() {
@@ -55,7 +55,7 @@ module.exports = {
                 stack.push(false);
 
                 if (enforceDeclarations && node.parent.type === "VariableDeclarator") {
-                    context.report(node.parent, "Expected a function declaration.");
+                    context.report({node: node.parent, message: "Expected a function declaration."});
                 }
             },
             "FunctionExpression:exit"() {
@@ -78,7 +78,7 @@ module.exports = {
                 const hasThisExpr = stack.pop();
 
                 if (enforceDeclarations && !hasThisExpr && node.parent.type === "VariableDeclarator") {
-                    context.report(node.parent, "Expected a function declaration.");
+                    context.report({node: node.parent, message: "Expected a function declaration."});
                 }
             };
         }