Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.babelrc.js should not be ignored by default #10089

Closed
jaydenseric opened this issue Mar 15, 2018 · 2 comments
Closed

.babelrc.js should not be ignored by default #10089

jaydenseric opened this issue Mar 15, 2018 · 2 comments
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion cli Relates to ESLint's command-line interface enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion

Comments

@jaydenseric
Copy link

By default ESLint ignores dot files and folders, presumably because they are often generated or temporary.

As an exception, .babelrc.js files should not be ignored by default. These commonly used files are manually authored and should be linted.

A lot of people either don't realise their babel configs are not being linted or they can't be bothered to mess around with eslintIgnore glob weirdness.

Tell us about your environment

  • ESLint Version: v4.18.2
  • Node Version: v9.8.0
  • npm Version: v5.7.1
@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Mar 15, 2018
@jaydenseric jaydenseric mentioned this issue Mar 16, 2018
Closed
@aladdin-add aladdin-add added enhancement This change enhances an existing feature of ESLint cli Relates to ESLint's command-line interface evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Mar 16, 2018
@not-an-aardvark
Copy link
Member

Thanks for the proposal. I don't think we should add special exceptions for the config files of specific tools, but it might be reasonable to just removing the dotfiles exception entirely, as you suggested in #9942. (However, we would need to still have an exception for things like .git/, which should presumably never be linted. I'm not sure what the specifics of that exception would look like.)

@not-an-aardvark not-an-aardvark mentioned this issue May 12, 2018
Closed
@daverusso daverusso mentioned this issue Jul 12, 2018
Closed
@not-an-aardvark
Copy link
Member

Closing in favor of #10341.

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jan 19, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion cli Relates to ESLint's command-line interface enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jaydenseric @not-an-aardvark @aladdin-add